feat: add broadcast functions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
requested changes
Aug 3, 2022
clabby
reviewed
Aug 3, 2022
clabby
reviewed
Aug 3, 2022
|
Addressed all comments @clabby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds versions of the deploy functions that will broadcast the tx. This needs to be done since if you try to use the
broadcastcheatcode, it will broadcast the deployment ofHuffConfig.One thing to note here is that if you do a raw
HuffDeployer.config().set_broadcast(true).deploy("Contract")in your script, it still will broadcast theHuffConfigcontract. As far as I can tell this is a bug in Foundry having something to do with the interaction between broadcast and DELEGATECALL, but let me know if there is some other valid reason for this behavior.fixes #21